Author |
Message |
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | Quoting StaNDarD: Quote: So it is working, except 'CustomRole' is not set to 'Casting by'. It seems to me that this is set to 'IMDbCreditSubtype' instead of 'DVDProfilerCustomRole'.
PS: The only field you used 'DVDProfilerCustomRole' is 'Co-producer', so I tried to change the value on this and it wouldn't be used there neither. So I guess this is a bug.
PPS: Even when this behavior is wanted - I think it should use 'DVDProfilerCustomRole' at least when 'IMDbCreditSubtype' is empty. "Other" is currently not recognized as a DVD Profiler category and that's why even your manual editing doesn't really work. | | | Karsten DVD Collectors Online
|
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | Quoting StaNDarD: Quote: I see a lot of crew on IMDb, which has a role like 'makeup: Sigourney Weaver' or 'makeup artist: Los Angeles live action'. Unfortunately those crew-members won't be recognized.
I don't know, if it's too difficult to strip everything starting with the double-point so they could be fetched too, but it would be great. Parsing crew is already a PITA and since I can be barely interested in who directed the movie I never put an overly effort into crew. For me it's like "Who the frak cares who did Sigourney's hairdo?" | | | Karsten DVD Collectors Online
|
|
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | Quoting DJ Doena: Quote: "Other" is currently not recognized as a DVD Profiler category... Would it be a big problem to include it? Quoting DJ Doena: Quote: ...and that's why even your manual editing doesn't really work. It is working apart from custom-roles, which are filled with 'wrong' data from your xml - and this will also happen with known DVD Profiler categories. Quoting DJ Doena: Quote: Parsing crew is already a PITA and since I can be barely interested in who directed the movie I never put an overly effort into crew. For me it's like "Who the frak cares who did Sigourney's hairdo?" Well, as I said: it would be great, if it's not too difficult. | | | |
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | Quoting StaNDarD: Quote:
Quoting DJ Doena:
Quote: ...and that's why even your manual editing doesn't really work. It is working apart from custom-roles, which are filled with 'wrong' data from your xml - and this will also happen with known DVD Profiler categories. That's the part I probably didn't understand. I just parsed "This Means War". The config file states: Quote:
<CreditType> <IMDbCreditType>Produced by</IMDbCreditType> <DVDProfilerCreditType>Production</DVDProfilerCreditType> <CreditSubtypeList> ... <CreditSubtype> <IMDbCreditSubtype>co-producer</IMDbCreditSubtype> <DVDProfilerCreditSubtype>Custom</DVDProfilerCreditSubtype> <DVDProfilerCustomRole>Co-Producer</DVDProfilerCustomRole> </CreditSubtype> </CreditSubtypeList> </CreditType>
So it says fill the IMDb role of "Produced by" / "Co-Producer" into the DVDP role of "Production" / "Other" (The UI says "Other", the XML must say "Custom") / "Co-Producer" and that's exactly what it does: Quote:
<?xml version="1.0" encoding="iso-8859-1"?> <CrewInformation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> <Title>Das gibt Ärger (2012)</Title> <Credits> <Credit FirstName="Ross" MiddleName="" LastName="Fanger" BirthYear="6771" CreditType="Production" CreditSubtype="Custom" CreditedAs="" CustomRole="Co-Producer" /> </Credits> </CrewInformation>
| | | Karsten DVD Collectors Online
|
|
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | Yes, but it does so because you've checked 'Schreibe individuelle Rolle groß'. I've tried to set 'DVDProfilerCustomRole' to 'Co - Producer' and still I got 'Co-Producer'. | | | |
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| |
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | I still am not able to see the problem. I added this to my Transformation.xml: Quote:
<CreditType> <IMDbCreditType>Stunts</IMDbCreditType> <DVDProfilerCreditType>Other</DVDProfilerCreditType> <CreditSubtypeList> <CreditSubtype> <IMDbCreditSubtype>stunt coordinator</IMDbCreditSubtype> <DVDProfilerCreditSubtype>Custom</DVDProfilerCreditSubtype> <DVDProfilerCustomRole>The Fall Guy</DVDProfilerCustomRole> </CreditSubtype> </CreditSubtypeList> </CreditType>
Now I parse This Means War: | | | Karsten DVD Collectors Online
|
|
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | I have this in my Transformation.xml: Quote: <CreditType> <IMDbCreditType>Casting by</IMDbCreditType> <DVDProfilerCreditType>Other</DVDProfilerCreditType> <CreditSubtypeList> <CreditSubtype> <IMDbCreditSubtype /> <DVDProfilerCreditSubtype>Custom</DVDProfilerCreditSubtype> <DVDProfilerCustomRole>Casting by</DVDProfilerCustomRole> </CreditSubtype> </CreditSubtypeList> </CreditType> As you see IMDbCreditSubtype is empty. That's because of this: The result is: De-selecting 'Retain custom roles' would bring up the correct custom role for casting, but I would lose all other ones. So, what I'd like to see, is the use of DVDProfilerCustomRole, when IMDbCreditSubtype is empty and DVDProfilerCreditSubtype is 'Custom'. | | | |
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| |
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | I don't like it - I love it! I thought about getting just 'Makeup', but getting 'Makeup: Sigourney Weaver' is even better. Thanks a lot. | | | |
|
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | I'm not sure if it's a bug or if I am just doing something wrong: I added 'M.D.' to 'Known Lastname Suffixes' and even restarted CCE2, but still I get this: I'd expected to get Harry//Demopoulos M.D. This is taken from Cobra. | | | |
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | Ugh, this is tricky.
You probably have the option set to split "J.K." into first and middle name.
So when that's set the name looks something like
Harry - Demopoulos - M. - D.
And then it checks the "D." and the "M." as possible last name suffix seperately.
I'll look into it. | | | Karsten DVD Collectors Online
|
|
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | Quoting DJ Doena: Quote: You probably have the option set to split "J.K." into first and middle name. Yes, I have this option set. | | | |
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | Don't sweat it, t's already solved. At the same time I cleaned up the KnownSuffixes.txt a bit, throwing out all teh entries that can't happen anyway. New version comes this evening. | | | Karsten DVD Collectors Online
|
|
Registered: March 31, 2007 | Posts: 662 |
| Posted: | | | | Thanks for your quick fix. Quoting DJ Doena: Quote: Better parsing of "Crew Role: Location Unit" Could you also add this one: | | | |
|
Registered: March 14, 2007 | Reputation: | Posts: 6,747 |
| Posted: | | | | Quoting StaNDarD: Quote: Could you also add this one:
What do you mean "add this one"? | | | Karsten DVD Collectors Online
|
|